sdc issueshttps://gitlab.leibniz-kis.de/groups/sdc/-/issues2021-07-07T11:26:58Zhttps://gitlab.leibniz-kis.de/sdc/gris/grisview/-/issues/12Readme: Add example of data2021-07-07T11:26:58ZCarl SchafferReadme: Add example of dataIn addition to the current readme, it would be nice to have an example dataset included. E.g. pull a sample dataset from the website and open that in grisviewer.
Or alternatively, put a sample folder on the KIS network, make it publica...In addition to the current readme, it would be nice to have an example dataset included. E.g. pull a sample dataset from the website and open that in grisviewer.
Or alternatively, put a sample folder on the KIS network, make it publically available and list it as a sample.grisview-releasehttps://gitlab.leibniz-kis.de/sdc/gris/grisview/-/issues/9proof of concept: run on selma2021-04-13T09:12:24ZCarl Schafferproof of concept: run on selmagrisview-releasehttps://gitlab.leibniz-kis.de/sdc/gris/grisview/-/issues/7testing strategy2021-04-13T08:15:54ZCarl Schaffertesting strategycurrently with !1 , testing only ensures that the project is installable. It would be very valuable to have a suite of tests that can programmatically verify the functional integrity of the project i.e. will it actually run if it is succ...currently with !1 , testing only ensures that the project is installable. It would be very valuable to have a suite of tests that can programmatically verify the functional integrity of the project i.e. will it actually run if it is successfuly installed.grisview-releasehttps://gitlab.leibniz-kis.de/sdc/gris/grisview/-/issues/4packaging2021-04-13T08:08:28ZCarl SchafferpackagingAdd automatic packaging to project
* [ ] decide on target format
* [ ] Add build to CI/CD pipeline
* [ ] Add manual step with push to package repository/download page (possibly on release only?)Add automatic packaging to project
* [ ] decide on target format
* [ ] Add build to CI/CD pipeline
* [ ] Add manual step with push to package repository/download page (possibly on release only?)grisview-releasehttps://gitlab.leibniz-kis.de/sdc/gris/grisview/-/issues/2Add Documentation2021-04-13T11:57:54ZCarl SchafferAdd DocumentationDocumentation needs to be added to the tool:
* [ ] installing
* [ ] getting started/running on a sample dataset (sample dataset using sdc as a data source (download data from web, extract, run grisviewer)
* [ ] overview of features
* [ ]...Documentation needs to be added to the tool:
* [ ] installing
* [ ] getting started/running on a sample dataset (sample dataset using sdc as a data source (download data from web, extract, run grisviewer)
* [ ] overview of features
* [ ] which requirements are there for data (e.g. l1 translated data)
Places where the documentation needs to be referenced:
* [ ] readme.md
* [ ] Entry to code overview page on confluence[here](https://leibniz-kis.atlassian.net/l/c/omh0EXD0)
* [ ] Short info/landing page as a child for documentation in the [manuals page](https://leibniz-kis.atlassian.net/l/c/p2aAmANN)
Do you want to use gitlab pages and readthedocs for documentation? This probably spawns a lot of smaller sub-issues, @guenter has a proof of concept to use gitlab pages and runners to automatically build and deploy the documentation. It might be more suited to technical/developer documentation, but definitely best practice.
* [ ] evaluate and plan readthedocs and gitlab pages strategygrisview-releasehttps://gitlab.leibniz-kis.de/sdc/gris/grisview/-/issues/1license2021-04-15T16:59:28ZCarl Schafferlicenseneeds a license, MIT?needs a license, MIT?grisview-releasehttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/193BBI: extname needs incremental file number2020-07-16T10:07:01ZCarl SchafferBBI: extname needs incremental file numberExtname needs to have an incremented file number so that it is unique within the pointing runExtname needs to have an incremented file number so that it is unique within the pointing runBBI Publicationhttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/177BBI Preview: Add full Obs identifier2020-07-16T10:06:32ZCarl SchafferBBI Preview: Add full Obs identifierAdd observation identifier to reco previewsAdd observation identifier to reco previewsBBI Publicationhttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/162bbi: add docstrings2020-07-16T10:08:01ZCarl Schafferbbi: add docstringsBBI Publicationhttps://gitlab.leibniz-kis.de/sdc/gris/gris-interactive/-/issues/2issue with appmode2023-08-03T07:21:26ZVigeesh Gangadharanissue with appmodeLaunching the binder throws<br>
`500: internal server error`
there seems to be an issue with the appmode.<br>
See: https://github.com/oschuett/appmode/issues/64Launching the binder throws<br>
`500: internal server error`
there seems to be an issue with the appmode.<br>
See: https://github.com/oschuett/appmode/issues/64Vigeesh GangadharanVigeesh Gangadharanhttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/311DeprecationWarning: pkg_resources is deprecated as an API.2023-07-27T10:00:26ZVigeesh GangadharanDeprecationWarning: pkg_resources is deprecated as an API.```
kistools_env/bin/gris_gen_maps:4: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html
__import__('pkg_resources').run_script('kis-tools==3.12.2', 'gris_gen_maps')
``````
kistools_env/bin/gris_gen_maps:4: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html
__import__('pkg_resources').run_script('kis-tools==3.12.2', 'gris_gen_maps')
```Vigeesh GangadharanVigeesh Gangadharanhttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/310Issue with gris location plot with disable-hmi-cache2023-07-25T10:00:38ZVigeesh GangadharanIssue with gris location plot with disable-hmi-cacheRunning `gris_location_plot` with `--disable-hmi-cache` gives me the following error:
```
gris_location_plot -v -o test --disable-hmi-cache -r 22 /dat/sdc/gris/20140922
/home/vigeesh/conda/envs/kistools_env/bin/gris_location_plot:4: De...Running `gris_location_plot` with `--disable-hmi-cache` gives me the following error:
```
gris_location_plot -v -o test --disable-hmi-cache -r 22 /dat/sdc/gris/20140922
/home/vigeesh/conda/envs/kistools_env/bin/gris_location_plot:4: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html
__import__('pkg_resources').run_script('kis-tools==3.12.2', 'gris_location_plot')
__ ___ __ _______. .___________. ______ ______ __ _______.
| |/ / | | / | | | / __ \ / __ \ | | / |
| ' / | | | (----` `---| |----`| | | | | | | | | | | (----`
| < | | \ \ | | | | | | | | | | | | \ \
| . \ | | .----) | | | | `--' | | `--' | | `----.----) |
|__|\__\ |__| |_______/ |__| \______/ \______/ |_______|_______/
1/0 files failed to download. Please check `.errors` for details
Files Downloaded: 0%| | 0/1 [01:27<?, ?file/s]
22sep14.022: 0%| | 0/1 [01:37<?, ?it/s]
Traceback (most recent call last):
File "/home/vigeesh/conda/envs/kistools_env/bin/gris_location_plot", line 4, in <module>
__import__('pkg_resources').run_script('kis-tools==3.12.2', 'gris_location_plot')
File "/home/vigeesh/conda/envs/kistools_env/lib/python3.11/site-packages/pkg_resources/__init__.py", line 722, in run_script
self.require(requires)[0].run_script(script_name, ns)
File "/home/vigeesh/conda/envs/kistools_env/lib/python3.11/site-packages/pkg_resources/__init__.py", line 1561, in run_script
exec(code, namespace, namespace)
File "/home/vigeesh/conda/envs/kistools_env/lib/python3.11/site-packages/kis_tools-3.12.2-py3.11.egg/EGG-INFO/scripts/gris_location_plot", line 27, in <module>
make_gris_locplots(folder, run=run, output_folder=output_folder, use_hmi_cache=use_hmi_cache,debug=debug)
File "/home/vigeesh/conda/envs/kistools_env/lib/python3.11/site-packages/kis_tools-3.12.2-py3.11.egg/kis_tools/gris/plotting.py", line 232, in make_gris_locplots
fig, ax = r.plot_location(use_hmi_cache=use_hmi_cache,debug=debug)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/vigeesh/conda/envs/kistools_env/lib/python3.11/site-packages/kis_tools-3.12.2-py3.11.egg/kis_tools/generic/observation.py", line 161, in plot_location
fig, ax = make_loc_plot(
^^^^^^^^^^^^^^
File "/home/vigeesh/conda/envs/kistools_env/lib/python3.11/site-packages/kis_tools-3.12.2-py3.11.egg/kis_tools/util/locplot.py", line 138, in make_loc_plot
hmi_map = get_continuum_map(date, use_hmi_cache)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/vigeesh/conda/envs/kistools_env/lib/python3.11/site-packages/kis_tools-3.12.2-py3.11.egg/kis_tools/util/locplot.py", line 262, in get_continuum_map
continuum_file = download_hmi_continuum(date, context_dir)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/vigeesh/conda/envs/kistools_env/lib/python3.11/site-packages/kis_tools-3.12.2-py3.11.egg/kis_tools/util/locplot.py", line 60, in download_hmi_continuum
continuum_file = pull_continuum(date, target)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/vigeesh/conda/envs/kistools_env/lib/python3.11/site-packages/kis_tools-3.12.2-py3.11.egg/kis_tools/util/locplot.py", line 88, in pull_continuum
file = Fido.fetch(row)[0]
~~~~~~~~~~~~~~~^^^
File "/home/vigeesh/conda/envs/kistools_env/lib/python3.11/collections/__init__.py", line 1241, in __getitem__
return self.data[i]
~~~~~~~~~^^^
IndexError: list index out of range
```Vigeesh GangadharanVigeesh Gangadharanhttps://gitlab.leibniz-kis.de/sdc/gris/grisinv/-/issues/51Array size mismatch2022-07-27T09:45:54ZVigeesh GangadharanArray size mismatch```
SDC:GRIS Inversion Pipeline: v0.6.0+4.gf83d1e4
Reading fits files 0/128: | | 0% (0.0s)
Traceback (most recent call last):
File "/home/vigeesh/conda/envs/gris_env_test/bin/vfisv", line 8, in <module>
...```
SDC:GRIS Inversion Pipeline: v0.6.0+4.gf83d1e4
Reading fits files 0/128: | | 0% (0.0s)
Traceback (most recent call last):
File "/home/vigeesh/conda/envs/gris_env_test/bin/vfisv", line 8, in <module>
sys.exit(main())
File "/home/vigeesh/conda/envs/gris_env_test/lib/python3.9/site-packages/click/core.py", line 829, in __call__
return self.main(*args, **kwargs)
File "/home/vigeesh/conda/envs/gris_env_test/lib/python3.9/site-packages/click/core.py", line 782, in main
rv = self.invoke(ctx)
File "/home/vigeesh/conda/envs/gris_env_test/lib/python3.9/site-packages/click/core.py", line 1066, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/home/vigeesh/conda/envs/gris_env_test/lib/python3.9/site-packages/click/core.py", line 610, in invoke
return callback(*args, **kwargs)
File "/home/vigeesh/conda/envs/gris_env_test/lib/python3.9/site-packages/grisinv/invert.py", line 2198, in main
data, stokes, header = vfisv(path, id, line, width,numproc,weights=weights)
File "/home/vigeesh/conda/envs/gris_env_test/lib/python3.9/site-packages/grisinv/invert.py", line 214, in vfisv
vfisv_data = VFISVpackage(path, id, line, width)
File "/home/vigeesh/conda/envs/gris_env_test/lib/python3.9/site-packages/grisinv/invert.py", line 1669, in __init__
self.get_data_slit()
File "/home/vigeesh/conda/envs/gris_env_test/lib/python3.9/site-packages/grisinv/invert.py", line 1921, in get_data_slit
self.SI[iff, ...],
ValueError: could not broadcast input array from shape (424,132) into shape (424,201)
```Vigeesh GangadharanVigeesh Gangadharanhttps://gitlab.leibniz-kis.de/sdc/gris/grisred/-/issues/7Incorrect calibration settings, flat and cal files are mixed up2022-05-27T15:25:08ZTaras YakobchukIncorrect calibration settings, flat and cal files are mixed upTelescope calibration files sometimes specified as flat field files, which results in the pipeline error. For example, below only runs 1, 4, 9 could be processed and added to the web archive. When using correct flat and cal files, pipeli...Telescope calibration files sometimes specified as flat field files, which results in the pipeline error. For example, below only runs 1, 4, 9 could be processed and added to the web archive. When using correct flat and cal files, pipeline completes successfully. Should investigate and correct automatically `gris_calibration_settings.csv` file
Example:
gris_calibration_settings.csv:
```
2019-10-10,1,10oct19.001,gris_v7,10oct19.000,,10oct19.008,,10830,,,,,
2019-10-10,2,10oct19.002,gris_v7,10oct19.008,,10oct19.000,,10830,,,,,
2019-10-10,3,10oct19.003,gris_v7,10oct19.008,,10oct19.005,,10830,,,,,
2019-10-10,4,10oct19.004,gris_v7,10oct19.000,,10oct19.008,,10830,,,,,
2019-10-10,6,10oct19.006,gris_v7,10oct19.008,,10oct19.005,,10830,,,,,
2019-10-10,7,10oct19.007,gris_v7,10oct19.008,,10oct19.005,,10830,,,,,
2019-10-10,9,10oct19.009,gris_v7,10oct19.011,,10oct19.008,,10830,,,,,
2019-10-10,12,10oct19.012,gris_v7,10oct19.008,,10oct19.011,,10830,,,,,
2019-10-10,13,10oct19.013,gris_v7,10oct19.008,,10oct19.011,,10830,,,,,
2019-10-10,14,10oct19.014,gris_v7,10oct19.008,,10oct19.011,,10830,,,,,
```
gris_archive_info.csv:
```
2019-10-10,0,/dat/sdc/gris/20191010/level0/10oct19.000,SLIT,1083,flat field,,complete,100.0
2019-10-10,1,/dat/sdc/gris/20191010/level0/10oct19.001-02,SLIT,1083,scanning,,error,100.0
2019-10-10,2,/dat/sdc/gris/20191010/level0/10oct19.002-01,SLIT,1083,scanning,Spicule,aborted,100.0
2019-10-10,3,/dat/sdc/gris/20191010/level0/10oct19.003-01,SLIT,1083,scanning,Spicule,aborted,100.0
2019-10-10,4,/dat/sdc/gris/20191010/level0/10oct19.004-02,SLIT,1083,scanning,,error,100.0
2019-10-10,5,/dat/sdc/gris/20191010/level0/10oct19.005,SLIT,1083,flat field,,complete,100.0
2019-10-10,6,/dat/sdc/gris/20191010/level0/10oct19.006,SLIT,1083,scanning,,error,100.0
2019-10-10,7,/dat/sdc/gris/20191010/level0/10oct19.007-01,SLIT,1083,scanning,,error,100.0
2019-10-10,8,/dat/sdc/gris/20191010/level0/10oct19.008,SLIT,1083,telescope cal.,,complete,100.0
2019-10-10,9,/dat/sdc/gris/20191010/level0/10oct19.009-02,SLIT,1083,scanning,Spicule,complete,100.0
2019-10-10,10,/dat/sdc/gris/20191010/level0/10oct19.010,SLIT,1083,flat field,,aborted,100.0
2019-10-10,11,/dat/sdc/gris/20191010/level0/10oct19.011,SLIT,1083,flat field,,complete,100.0
2019-10-10,12,/dat/sdc/gris/20191010/level0/10oct19.012,SLIT,1083,scanning,Quiet Sun,complete,100.0
2019-10-10,13,/dat/sdc/gris/20191010/level0/10oct19.013,SLIT,1083,scanning,Quiet Sun,complete,100.0
2019-10-10,14,/dat/sdc/gris/20191010/level0/10oct19.014,SLIT,1083,scanning,Quiet Sun,complete,100.0
```Taras YakobchukTaras Yakobchukhttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/309Better Error messages for failure due to untranslated data2022-04-27T10:55:09ZCarl SchafferBetter Error messages for failure due to untranslated dataBoth `gris_location_plot` and `gris_gen_maps` fail when pointed at untranslated data. Te error messages do not list this as the cuse, should be improved.Both `gris_location_plot` and `gris_gen_maps` fail when pointed at untranslated data. Te error messages do not list this as the cuse, should be improved.https://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/308Stepsize value might be wrong for old data2022-04-26T07:25:07ZCarl SchafferStepsize value might be wrong for old dataThe Cassda-Gui prints the following message on loading old datasets e.g. 20150603_008:
![image](/uploads/8a990cd860cc47c77c487519629b6bed/image.png)
This implies that the step size value in the header might not be correct. InvestigateThe Cassda-Gui prints the following message on loading old datasets e.g. 20150603_008:
![image](/uploads/8a990cd860cc47c77c487519629b6bed/image.png)
This implies that the step size value in the header might not be correct. Investigatehttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/307use updated tag list for header translation2022-03-31T08:28:31ZCarl Schafferuse updated tag list for header translationThe heqader translator has a `to_OBS_TRGT`method that is not being used. It should be modified to be used. Also the `.csv` file in kis_tools/gris/resources containing the target tag information should be extended with Sanis tags from 202...The heqader translator has a `to_OBS_TRGT`method that is not being used. It should be modified to be used. Also the `.csv` file in kis_tools/gris/resources containing the target tag information should be extended with Sanis tags from 2022:
[missing_targets_main_tag_added.csv](/uploads/6ce45a8503f63c1443b1388488a48dcf/missing_targets_main_tag_added.csv)https://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/306Graceful exit for gris_lot_cont_corr2022-03-17T13:34:45ZCarl SchafferGraceful exit for gris_lot_cont_corrPlot cont corr should exit with a warning if no files are found:
```
Wed Mar 16 01:43:35 CET 2022
running gris_plot_cont_corr --store /dat/sdc/gris/20191003/context_data/*cont_corr*sav
__ ___ __ _______. .___________. _____...Plot cont corr should exit with a warning if no files are found:
```
Wed Mar 16 01:43:35 CET 2022
running gris_plot_cont_corr --store /dat/sdc/gris/20191003/context_data/*cont_corr*sav
__ ___ __ _______. .___________. ______ ______ __ _______.
| |/ / | | / | | | / __ \ / __ \ | | / |
| ' / | | | (----` `---| |----`| | | | | | | | | | | (----`
| < | | \ \ | | | | | | | | | | | | \ \
| . \ | | .----) | | | | `--' | | `--' | | `----.----) |
|__|\__\ |__| |_______/ |__| \______/ \______/ |_______|_______/
Traceback (most recent call last):
File "/home/schaffer/anaconda3/envs/sdc/bin/gris_plot_cont_corr", line 7, in <module>
exec(compile(f.read(), __file__, 'exec'))
File "/dat/schaffer/projects/kis_tools/bin/gris_plot_cont_corr", line 27, in <module>
fig = plot_cont_corr(i)
File "/dat/schaffer/projects/kis_tools/kis_tools/gris/plotting.py", line 140, in plot_cont_corr
data = readsav(path)
File "/home/schaffer/anaconda3/envs/sdc/lib/python3.10/site-packages/scipy/io/idl.py", line 738, in readsav
f = open(file_name, 'rb')
FileNotFoundError: [Errno 2] No such file or directory: '/dat/sdc/gris/20191003/context_data/*cont_corr*sav'
/var/lib/condor/execute/dir_326475/condor_exec.exe: line 105: [: ==: unary operator expected
```https://gitlab.leibniz-kis.de/sdc/gris/cassda_gui/-/issues/2write setup instructions2022-03-15T08:23:43ZCarl Schafferwrite setup instructionshttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/305WCS errors for unequal step-sizes2022-03-14T17:37:09ZCarl SchafferWCS errors for unequal step-sizes![image](/uploads/3f72dc7616b40682f70569e5c96d3d30/image.png)
Gris Coordinates recovered from the first wcs sometimes will go in the wrong direction. Also ther is an offset between the coordinates fed into the WCS generator and the ones...![image](/uploads/3f72dc7616b40682f70569e5c96d3d30/image.png)
Gris Coordinates recovered from the first wcs sometimes will go in the wrong direction. Also ther is an offset between the coordinates fed into the WCS generator and the ones reconstructed from the header. It's something with the rotation of the different step widths in X and Y direction. Cant't figure it out, spent one week now.
to reproduce run test_coords /test_wcs for commit 50ee44ce819c3229adb91e2d425e26d4fdbe0b9b