kis_headers issueshttps://gitlab.leibniz-kis.de/sdc/kis_headers/-/issues2021-03-01T15:23:42Zhttps://gitlab.leibniz-kis.de/sdc/kis_headers/-/issues/6feature: standard header creation wrapper2021-03-01T15:23:42ZCarl Schafferfeature: standard header creation wrapperWriting a general tool to wrap numerical arrays in fits headers would be a huge benefit to SDC.
Theere are already some preliminary designs/concepts here:
https://leibniz-kis.atlassian.net/wiki/spaces/SP/pages/176030361/2020-07-14+Mee...Writing a general tool to wrap numerical arrays in fits headers would be a huge benefit to SDC.
Theere are already some preliminary designs/concepts here:
https://leibniz-kis.atlassian.net/wiki/spaces/SP/pages/176030361/2020-07-14+Meeting+Notes+header+toolshttps://gitlab.leibniz-kis.de/sdc/kis_headers/-/issues/4validate header should raise an exception instead of returning none2020-07-16T10:30:10ZCarl Schaffervalidate header should raise an exception instead of returning none@yakobchuk
I think `validate_header` should raise an error instead of a warning if you try to validate a header for an unknown instrument. I think it's okay to fail hard here because the function simply can't o anything if it doesn't kn...@yakobchuk
I think `validate_header` should raise an error instead of a warning if you try to validate a header for an unknown instrument. I think it's okay to fail hard here because the function simply can't o anything if it doesn't know what to check for. In this case it should fail spectacularly instead of returning `None` and exiting quietly... In the latter case it's pretty hard to track down the bug.
o something like: `RaiseNotImplementedError("The instrument [NAME] is not implemented here yet")` should do the trick.https://gitlab.leibniz-kis.de/sdc/kis_headers/-/issues/2header template for gsjc2020-07-16T10:28:28ZCarl Schafferheader template for gsjcnot that urgent but necessary at some pointnot that urgent but necessary at some point