Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • K kis_headers
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3
    • Issues 3
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • sdc
  • kis_headers
  • Issues
  • #4

Closed
Open
Created Apr 30, 2020 by Carl Schaffer@schafferOwner

validate header should raise an exception instead of returning none

@yakobchuk I think validate_header should raise an error instead of a warning if you try to validate a header for an unknown instrument. I think it's okay to fail hard here because the function simply can't o anything if it doesn't know what to check for. In this case it should fail spectacularly instead of returning None and exiting quietly... In the latter case it's pretty hard to track down the bug.

o something like: RaiseNotImplementedError("The instrument [NAME] is not implemented here yet") should do the trick.

Assignee
Assign to
Time tracking