kis_tools issueshttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues2019-07-25T12:32:26Zhttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/153lars coordinates2019-07-25T12:32:26ZCarl Schafferlars coordinatesLars coordinates are messed up somehow. The keywords specifying the location on the disk exhibit different problems:
Coordinates are given via two redundant sets of keywords:
1. `SHG_LAT` and `SHG_LON` give the [Stonyhurst Heliographic C...Lars coordinates are messed up somehow. The keywords specifying the location on the disk exhibit different problems:
Coordinates are given via two redundant sets of keywords:
1. `SHG_LAT` and `SHG_LON` give the [Stonyhurst Heliographic Coordinates](http://www.mssl.ucl.ac.uk/grid/iau/extra/local_copy/coordinates.pdf) position in degrees according to the header
2. `HPC_X` and `HPC_Y` give heliographic coordinates in arcsec
If these coordinate information sets match up, there should be a steady relationship between them. Plotting reveals some sort of mismatch:
![Selection_053](/uploads/a1a5b33617418d874e737f37901f8763/Selection_053.png)https://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/235lars wavelength2020-05-29T12:37:42ZCarl Schafferlars wavelengthLars l1 files do not contain a Wavelength keyword by default. JLB provided a dirty fix:
```
; Routine to add the correct wavelength to a given LARS fits file
PRO ldrc_insert_wavelength, file
data=readfits(file,hdr)
lam =mrdfits(file,1...Lars l1 files do not contain a Wavelength keyword by default. JLB provided a dirty fix:
```
; Routine to add the correct wavelength to a given LARS fits file
PRO ldrc_insert_wavelength, file
data=readfits(file,hdr)
lam =mrdfits(file,1,h1)
meta=mrdfits(file,2,h2)
lambda = round(mean(lam)*1d10)
;;copy par and insert value
val = sxpar (hdr, 'WAVELNTH', comment=comment, count=count)
print,'Adding Wavelength',lambda,' to ',file
fxaddpar, hdr, 'WAVELNTH', lambda, comment
mwrfits, data, file, hdr, iscale=[1, 32768], /silent, /create
mwrfits, lam, file, h1, /silent
mwrfits, meta, file, h2, /silent
END
```
This fix works for adding wavelengths to `*chvtt.fits` files. On the long run, this should be added to the LARS pipeline.https://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/157gris handle trailing maps2019-08-19T07:38:40ZCarl Schaffergris handle trailing mapsremove trailing maps or not?remove trailing maps or not?https://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/203GRIS: Cross correlation file structure2019-12-12T09:25:18ZCarl SchafferGRIS: Cross correlation file structureThere are different structures for the cross correlation files. sometimes `slit_orientation` is used, sometimes `slit_angle` this should be made uniform.There are different structures for the cross correlation files. sometimes `slit_orientation` is used, sometimes `slit_angle` this should be made uniform.GRIS CoordinatesCarl SchafferCarl Schafferhttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/218Gris: Some runs not translated2020-05-27T11:54:13ZCarl SchafferGris: Some runs not translatedSome runs do not seem to be fully translated:
![image](/uploads/847f0203e1fd5ad24816ffa21726e518/image.png)
List of the first split files of these runs:
gris_20140503_140502_l1p_012_001_0001.fits
gris_20140503_145531_l1p_015...Some runs do not seem to be fully translated:
![image](/uploads/847f0203e1fd5ad24816ffa21726e518/image.png)
List of the first split files of these runs:
gris_20140503_140502_l1p_012_001_0001.fits
gris_20140503_145531_l1p_015_001_0001.fits
gris_20140503_154906_l1p_018_001_0001.fits
gris_20140503_161857_l1p_020_001_0001.fits
gris_20140503_162943_l1p_021_001_0001.fits
gris_20140503_164102_l1p_022_001_0001.fits
gris_20140503_165223_l1p_023_001_0001.fits
gris_20140503_171735_l1p_026_001_0001.fits
gris_20140503_174110_l1p_027_001_0001.fits
gris_20150603_082644_l1p_004_001_0001.fits
gris_20150603_084246_l1p_005_001_0001.fits
gris_20150603_091312_l1p_006_001_0001.fits
gris_20150603_095403_l1p_008_001_0001.fits
gris_20150603_102339_l1p_009_001_0001.fits
gris_20160602_075844_l1p_001_001_0001.fits
gris_20160602_081620_l1p_002_001_0001.fits
gris_20160602_095847_l1p_006_001_0001.fits
gris_20160602_101825_l1p_007_001_0001.fits
gris_20170616_092551_l1p_005_001_0001.fits
gris_20170616_103511_l1p_007_001_0001.fits
gris_20180504_155639_l1p_016_001_0001.fits
gris_20180504_155905_l1p_017_001_0001.fits
gris_20180504_163932_l1p_020_001_0001.fits
gris_20180504_170742_l1p_021_001_0001.fitshttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/219OBSGEO Coordinates2020-11-27T13:47:26ZCarl SchafferOBSGEO CoordinatesOBSGEO coordinates in FITS header do not point to OT, but to Roque de los muchachos. This means ALL fits files for GRIS are invalid (at least here)
![image](/uploads/8aa28cc99b1f10f7d042189603a651bc/image.png)
![image](/uploads/e30bba9...OBSGEO coordinates in FITS header do not point to OT, but to Roque de los muchachos. This means ALL fits files for GRIS are invalid (at least here)
![image](/uploads/8aa28cc99b1f10f7d042189603a651bc/image.png)
![image](/uploads/e30bba90093adfb7694fea4986cc1efb/image.png)reimport with kharonhttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/220Data Problem: Lars and Gris Logfiles have same name2020-04-09T07:43:37ZCarl SchafferData Problem: Lars and Gris Logfiles have same nameLogfiles from GRIS and LARS are not distinguishable by filename. This might lead to problems down the road, as the importer assumes files to be associable to an instrument by their name.
The Problem is not really severe, as LARS logfil...Logfiles from GRIS and LARS are not distinguishable by filename. This might lead to problems down the road, as the importer assumes files to be associable to an instrument by their name.
The Problem is not really severe, as LARS logfiles are currently generated on the fly anyway, but this needs to be taken into account when reimporting LARS data.https://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/254Gris WCS: CTYPE should be HP instead of HG2021-02-11T17:34:08ZCarl SchafferGris WCS: CTYPE should be HP instead of HGExcempt from rocketchat:
> Vigeesh:
> Question about GRIS data header
> ```
> WCSNAME = 'Helioprojective Cartesian' / nan
> CTYPE1 = 'HGLN-TAN' / Type of coordinates along axis 1
> CUNIT1 = 'arcsec ' / Units alon...Excempt from rocketchat:
> Vigeesh:
> Question about GRIS data header
> ```
> WCSNAME = 'Helioprojective Cartesian' / nan
> CTYPE1 = 'HGLN-TAN' / Type of coordinates along axis 1
> CUNIT1 = 'arcsec ' / Units along axis 1
> CRPIX1 = 0 / Reference pixel
> CRVAL1 = -393.014 / Value at reference pixel on axis 1
> CDELT1 = 0.027174 / Sampling along axis 1
> ```
> HGLN-TAN according to Thompson et al refers to Stonyhurst heliographic longitude
> so, I'm a bit confused about why it is called "Helioprojective Cartesian"?
> also the CDELT1 is in HGLN-TAN or HPLN-TAN?
>
> schaffer
> 10:56 AM
> You're right, that is inconsistent. I believe CTYPE should be HPLT-TAN, at least that is what is being done under the hood. I'll open an issue and correct this in all files sometime in the near future.
* [x] fix code
* [x] re-format files
* [ ] re-upload files to archiveWCS fixeshttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/289IFU Coordinates2022-01-28T15:50:52ZCarl SchafferIFU CoordinatesIFU coordinate calculation is *horrible* the stepsize per pixel is off by about an order of 200 and it is not clear where where the center coordinates reference off or what the angles mean.
The calculation in `kis_tools.gris.ifu_fits_f...IFU coordinate calculation is *horrible* the stepsize per pixel is off by about an order of 200 and it is not clear where where the center coordinates reference off or what the angles mean.
The calculation in `kis_tools.gris.ifu_fits_file.IFUFitsFile._coords_from_simple_header` need to be completely re-written or at least validated.
I don't have time to do this now as we need to get IFU data running for the V1 release, so the best I can do is to increase the uncertainties to a full solar disk and issue a warning each time the function is used.Carl SchafferCarl Schafferhttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/297GRIS data is flipped depending on step-angle2022-04-21T10:46:49ZCarl SchafferGRIS data is flipped depending on step-angleDepending on how the slit data is scanned, images are flipped w.r.t. HMI.
We should consider serving flipped data to the end-users instead of what we're doing right now.
* [ ] Check whether this is already done somewhere
* [ ] Evaluat...Depending on how the slit data is scanned, images are flipped w.r.t. HMI.
We should consider serving flipped data to the end-users instead of what we're doing right now.
* [ ] Check whether this is already done somewhere
* [ ] Evaluate how much effort a fix would be
* [ ] decide on actionCarl SchafferCarl Schaffer2021-11-30