kis_tools issueshttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues2020-10-16T09:52:32Zhttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/120CI add testing as CI step2020-10-16T09:52:32ZCarl SchafferCI add testing as CI stephttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/248gris targets: redundant vocabulary2021-02-11T17:36:34ZCarl Schaffergris targets: redundant vocabulary![image](/uploads/5323c1dd8286fbba786a89f50886f007/image.png)
The targets specified in the headers and or db are not consistent. e.g. `Emerging flux Region` and `Emerging Flux Reg.` need to be consolidated.
Full consolidation includes...![image](/uploads/5323c1dd8286fbba786a89f50886f007/image.png)
The targets specified in the headers and or db are not consistent. e.g. `Emerging flux Region` and `Emerging Flux Reg.` need to be consolidated.
Full consolidation includes:
* [ ] Check where the tag names originate
* [ ] Decide on a consistent naming convention
* [ ] Open issues regarding enforcing and documenting said scheme
* [ ] Fix the names in all datasets, starting at L0 headers
* [ ] Fix the names in the corresponding observation entrieshttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/250mapgen: IQUV previews2020-10-16T09:49:51ZCarl Schaffermapgen: IQUV previewsAdd QUV previews to GRISAdd QUV previews to GRIShttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/271clean GRIS header2021-03-22T08:26:49ZCarl Schafferclean GRIS headerAfter discussing with Manolo and Carlos while working on [the slit orientation issue](https://leibniz-kis.atlassian.net/browse/SR-99?atlOrigin=eyJpIjoiMTE2ZjAzN2EwNjlhNDc5MmFiYTdmMDYzZTNkOGYyOTkiLCJwIjoiaiJ9) I found out that some of the...After discussing with Manolo and Carlos while working on [the slit orientation issue](https://leibniz-kis.atlassian.net/browse/SR-99?atlOrigin=eyJpIjoiMTE2ZjAzN2EwNjlhNDc5MmFiYTdmMDYzZTNkOGYyOTkiLCJwIjoiaiJ9) I found out that some of the values we are propagating in the GRIS header are not correct, they might:
* be historic values such as `SLITORIE` which do not have a well-defined or obvious function
* be values that apply only to observations but not single slit positions (e.g. `AZIMUT`, `ELEVATION`)
* be unreliable due to different ephemerides code used for producing them/not be compliant with the telescope's definitions (again `AZIMUTH`)
For fully consistent headers, we would need to go through each value, assess the definition and validity, document that and throw out all confusing values.https://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/276refactor gdbs implementation2021-03-26T10:59:38ZCarl Schafferrefactor gdbs implementationGDBS implementation is not universal, testing is dependent on the availablity of the gdbs host, needs more flexible and clearer implementation and interfaceGDBS implementation is not universal, testing is dependent on the availablity of the gdbs host, needs more flexible and clearer implementation and interfacehttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/285remove or fix pypeline dependency in bbi tools2021-10-11T13:23:21ZCarl Schafferremove or fix pypeline dependency in bbi toolsThe bbi tools are dependent on the python wrapper for the BBI pipeline written by Sebastian Hoch ( see https://gitlab.leibniz-kis.de/sdc/bbi/pypeline) this project is not installable or documented. Most of the bbi-related code in kis too...The bbi tools are dependent on the python wrapper for the BBI pipeline written by Sebastian Hoch ( see https://gitlab.leibniz-kis.de/sdc/bbi/pypeline) this project is not installable or documented. Most of the bbi-related code in kis tools might be broken.https://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/289IFU Coordinates2022-01-28T15:50:52ZCarl SchafferIFU CoordinatesIFU coordinate calculation is *horrible* the stepsize per pixel is off by about an order of 200 and it is not clear where where the center coordinates reference off or what the angles mean.
The calculation in `kis_tools.gris.ifu_fits_f...IFU coordinate calculation is *horrible* the stepsize per pixel is off by about an order of 200 and it is not clear where where the center coordinates reference off or what the angles mean.
The calculation in `kis_tools.gris.ifu_fits_file.IFUFitsFile._coords_from_simple_header` need to be completely re-written or at least validated.
I don't have time to do this now as we need to get IFU data running for the V1 release, so the best I can do is to increase the uncertainties to a full solar disk and issue a warning each time the function is used.Carl SchafferCarl Schafferhttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/292IFU previews become very large as GIFS2021-11-14T20:02:35ZCarl SchafferIFU previews become very large as GIFSSwitch to different format, a 300 step GIF ends up at around 60MB, not feasible for quick look loadingSwitch to different format, a 300 step GIF ends up at around 60MB, not feasible for quick look loadinghttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/293gris/IFU instrument segmentation2021-11-14T21:36:34ZCarl Schaffergris/IFU instrument segmentationa lot of the gris and IFU files are problematic due to their names that could fit to either instrument.
e.g. IFU continuum correction files would be added to the GRIS database by default.
This ambiguity needs to be addressed.a lot of the gris and IFU files are problematic due to their names that could fit to either instrument.
e.g. IFU continuum correction files would be added to the GRIS database by default.
This ambiguity needs to be addressed.https://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/305WCS errors for unequal step-sizes2022-03-14T17:37:09ZCarl SchafferWCS errors for unequal step-sizes![image](/uploads/3f72dc7616b40682f70569e5c96d3d30/image.png)
Gris Coordinates recovered from the first wcs sometimes will go in the wrong direction. Also ther is an offset between the coordinates fed into the WCS generator and the ones...![image](/uploads/3f72dc7616b40682f70569e5c96d3d30/image.png)
Gris Coordinates recovered from the first wcs sometimes will go in the wrong direction. Also ther is an offset between the coordinates fed into the WCS generator and the ones reconstructed from the header. It's something with the rotation of the different step widths in X and Y direction. Cant't figure it out, spent one week now.
to reproduce run test_coords /test_wcs for commit 50ee44ce819c3229adb91e2d425e26d4fdbe0b9b