kis_tools issueshttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues2021-05-11T08:31:58Zhttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/186GRIS Coordinates: Solar Rotation2021-05-11T08:31:58ZCarl SchafferGRIS Coordinates: Solar RotationWhen using the updated GRIS data, Morten and Adur were not 100 percent sure whether the coordinates specified in the WCS keywords for the slit kws were correct. Definitely check this and write down some evidence.
Also check:
- Blue and...When using the updated GRIS data, Morten and Adur were not 100 percent sure whether the coordinates specified in the WCS keywords for the slit kws were correct. Definitely check this and write down some evidence.
Also check:
- Blue and Red observations
- Multimap observations
- Sit and Stare
- Polarimetric observations
Steps:
1. Collect testing data
2. Implement plotting of the coverage over a concurrent HMI Image
3. Compare with image content
4. Document results somewhere, eg here on gitlabhttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/248gris targets: redundant vocabulary2021-02-11T17:36:34ZCarl Schaffergris targets: redundant vocabulary![image](/uploads/5323c1dd8286fbba786a89f50886f007/image.png)
The targets specified in the headers and or db are not consistent. e.g. `Emerging flux Region` and `Emerging Flux Reg.` need to be consolidated.
Full consolidation includes...![image](/uploads/5323c1dd8286fbba786a89f50886f007/image.png)
The targets specified in the headers and or db are not consistent. e.g. `Emerging flux Region` and `Emerging Flux Reg.` need to be consolidated.
Full consolidation includes:
* [ ] Check where the tag names originate
* [ ] Decide on a consistent naming convention
* [ ] Open issues regarding enforcing and documenting said scheme
* [ ] Fix the names in all datasets, starting at L0 headers
* [ ] Fix the names in the corresponding observation entrieshttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/250mapgen: IQUV previews2020-10-16T09:49:51ZCarl Schaffermapgen: IQUV previewsAdd QUV previews to GRISAdd QUV previews to GRIShttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/271clean GRIS header2021-03-22T08:26:49ZCarl Schafferclean GRIS headerAfter discussing with Manolo and Carlos while working on [the slit orientation issue](https://leibniz-kis.atlassian.net/browse/SR-99?atlOrigin=eyJpIjoiMTE2ZjAzN2EwNjlhNDc5MmFiYTdmMDYzZTNkOGYyOTkiLCJwIjoiaiJ9) I found out that some of the...After discussing with Manolo and Carlos while working on [the slit orientation issue](https://leibniz-kis.atlassian.net/browse/SR-99?atlOrigin=eyJpIjoiMTE2ZjAzN2EwNjlhNDc5MmFiYTdmMDYzZTNkOGYyOTkiLCJwIjoiaiJ9) I found out that some of the values we are propagating in the GRIS header are not correct, they might:
* be historic values such as `SLITORIE` which do not have a well-defined or obvious function
* be values that apply only to observations but not single slit positions (e.g. `AZIMUT`, `ELEVATION`)
* be unreliable due to different ephemerides code used for producing them/not be compliant with the telescope's definitions (again `AZIMUTH`)
For fully consistent headers, we would need to go through each value, assess the definition and validity, document that and throw out all confusing values.https://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/295add grepfits for full calib pipeline2021-11-19T17:41:46ZCarl Schafferadd grepfits for full calib pipelinecalibration settings retrieval can be largely improved using grepfits and get last l0:
```
echo $(for i in /instruments/gris/202*;do ./gris_l0_info.sh $i;done) > last_l0_file_per_run.txt
grepfits "IMGSYS WAVELENG MEASURE TARGET FILESTAT...calibration settings retrieval can be largely improved using grepfits and get last l0:
```
echo $(for i in /instruments/gris/202*;do ./gris_l0_info.sh $i;done) > last_l0_file_per_run.txt
grepfits "IMGSYS WAVELENG MEASURE TARGET FILESTAT EXPTIME" $(cat last_l0_file_per_run.txt ) |tee $(date '+%Y-%m-%d')_gris_l0_info.csv
```
the output file can then replace the file in `kis_tools.gris.resources` and be used to generate calibration settings.
The shell scripts have been added to `kis_tools.gris.calib_settings`https://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/301translate_header gracious error code on missing run2022-02-01T14:05:35ZCarl Schaffertranslate_header gracious error code on missing run```
__ ___ __ _______. .___________. ______ ______ __ _______.
| |/ / | | / | | | / __ \ / __ \ | | / |
| ' / | | | (----` `---| |----`| | | | | | ...```
__ ___ __ _______. .___________. ______ ______ __ _______.
| |/ / | | / | | | / __ \ / __ \ | | / |
| ' / | | | (----` `---| |----`| | | | | | | | | | | (----`
| < | | \ \ | | | | | | | | | | | | \ \
| . \ | | .----) | | | | `--' | | `--' | | `----.----) |
|__|\__\ |__| |_______/ |__| \______/ \______/ |_______|_______/
Traceback (most recent call last):
File "/usr/local/bin/gris_translate_header", line 9, in <module>
run_translate_header(sys.argv[1:])
File "/usr/local/lib/python3.8/site-packages/kis_tools/gris/headers/translate_header.py", line 307, in run_translate_header
files = groupby_gris_run(files)[args.run]
KeyError: 2
```
If translate header is called with a non-existent run, the tool should exit graciously. Same goes for the splitter toolhttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/305WCS errors for unequal step-sizes2022-03-14T17:37:09ZCarl SchafferWCS errors for unequal step-sizes![image](/uploads/3f72dc7616b40682f70569e5c96d3d30/image.png)
Gris Coordinates recovered from the first wcs sometimes will go in the wrong direction. Also ther is an offset between the coordinates fed into the WCS generator and the ones...![image](/uploads/3f72dc7616b40682f70569e5c96d3d30/image.png)
Gris Coordinates recovered from the first wcs sometimes will go in the wrong direction. Also ther is an offset between the coordinates fed into the WCS generator and the ones reconstructed from the header. It's something with the rotation of the different step widths in X and Y direction. Cant't figure it out, spent one week now.
to reproduce run test_coords /test_wcs for commit 50ee44ce819c3229adb91e2d425e26d4fdbe0b9bhttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/307use updated tag list for header translation2022-03-31T08:28:31ZCarl Schafferuse updated tag list for header translationThe heqader translator has a `to_OBS_TRGT`method that is not being used. It should be modified to be used. Also the `.csv` file in kis_tools/gris/resources containing the target tag information should be extended with Sanis tags from 202...The heqader translator has a `to_OBS_TRGT`method that is not being used. It should be modified to be used. Also the `.csv` file in kis_tools/gris/resources containing the target tag information should be extended with Sanis tags from 2022:
[missing_targets_main_tag_added.csv](/uploads/6ce45a8503f63c1443b1388488a48dcf/missing_targets_main_tag_added.csv)https://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/308Stepsize value might be wrong for old data2022-04-26T07:25:07ZCarl SchafferStepsize value might be wrong for old dataThe Cassda-Gui prints the following message on loading old datasets e.g. 20150603_008:
![image](/uploads/8a990cd860cc47c77c487519629b6bed/image.png)
This implies that the step size value in the header might not be correct. InvestigateThe Cassda-Gui prints the following message on loading old datasets e.g. 20150603_008:
![image](/uploads/8a990cd860cc47c77c487519629b6bed/image.png)
This implies that the step size value in the header might not be correct. Investigatehttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/309Better Error messages for failure due to untranslated data2022-04-27T10:55:09ZCarl SchafferBetter Error messages for failure due to untranslated dataBoth `gris_location_plot` and `gris_gen_maps` fail when pointed at untranslated data. Te error messages do not list this as the cuse, should be improved.Both `gris_location_plot` and `gris_gen_maps` fail when pointed at untranslated data. Te error messages do not list this as the cuse, should be improved.