kis_tools issueshttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues2021-02-11T17:32:42Zhttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/259GRIS Coordinates without cross correlation2021-02-11T17:32:42ZCarl SchafferGRIS Coordinates without cross correlation
In general we want to have a full cross correlation of coordinates fro GRIS maps. This is the preferred method of getting coordinates for WCS keywords. Back when we did this, we assumed SLITPOS_X and SLITPOS_Y to give coordinates in a ...
In general we want to have a full cross correlation of coordinates fro GRIS maps. This is the preferred method of getting coordinates for WCS keywords. Back when we did this, we assumed SLITPOS_X and SLITPOS_Y to give coordinates in a system that is aligned with the solar axis and for that matter with the HMI system.
Looking at the location guesses from the Mercury transit of last year, it seems very likely, that there is an additional rotation between the systems that we don't account for. This would also affect our uncertainty estimates for non-correlated files. See https://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/199
![transit](/uploads/9e4bb8c70cef34cb3b68c6fa0964b603/transit.gif)WCS fixeshttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/258GRIS Header Observer Metadata2021-02-23T10:01:48ZCarl SchafferGRIS Header Observer Metadata![Clipboard_-_November_26__2020_2_54_PM](/uploads/100ec7c094c94884841d2cfe7fccea67/Clipboard_-_November_26__2020_2_54_PM.png)
We should add the HGLN_obs and dsun_ref keywords to the header to silence the astropy warning![Clipboard_-_November_26__2020_2_54_PM](/uploads/100ec7c094c94884841d2cfe7fccea67/Clipboard_-_November_26__2020_2_54_PM.png)
We should add the HGLN_obs and dsun_ref keywords to the header to silence the astropy warningWCS fixesCarl SchafferCarl Schafferhttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/257CTYPE inconsistency in header for data in spectroscopic mode2021-02-11T17:33:36ZVigeesh GangadharanCTYPE inconsistency in header for data in spectroscopic modeFor dataset in spectroscopic mode, the first axis seems to be always wavelength.<br>
But this is not consistent with the CTYPE-_i_ keywords later.
e.g.
```
SIMPLE = T / conforms to FITS standard ...For dataset in spectroscopic mode, the first axis seems to be always wavelength.<br>
But this is not consistent with the CTYPE-_i_ keywords later.
e.g.
```
SIMPLE = T / conforms to FITS standard
BITPIX = 32 / array data type
NAXIS = 3 / number of array dimensions
NAXIS1 = 1010 / Length of data axis 1
NAXIS2 = 484 / Length of data axis 2
NAXIS3 = 1 / Length of data axis 3
FILENAME= 'gris_20160613_120408_l1s_008_120_0029.fits' / Name of file
EXTNAME = '20160613_008_120_0029' / Unique HDU name
POINT_ID= '20160613_008' / Unique (re-)pointing ID
OBS_TRGT= 'Sunspot(s)' / Observation Target
WCSNAME = 'Helioprojective Cartesian' / nan
CTYPE1 = 'HGLN-TAN' / Type of coordinates along axis 1
CUNIT1 = 'arcsec ' / Units along axis 1
CRPIX1 = 0 / Reference pixel
CRVAL1 = 297.671 / Value at reference pixel on axis 1
CDELT1 = 0.080792 / Sampling along axis 1
CSYER1 = 1900 / Systematic Error along axis 1
CTYPE2 = 'HGLT-TAN' / Type of coordinates along axis 2
CUNIT2 = 'arcsec ' / Units along axis 2
CRPIX2 = 0 / Reference pixel
CRVAL2 = 408.258 / Value at reference pixel on axis 2
CDELT2 = 0.080792 / Sampling along axis 2
CSYER2 = 1900 / Systematic Error along axis 2
CTYPE3 = 'WAVE ' / Type of coordinates along axis 3
CUNIT3 = 'Angstrom' / Units along axis 3
CRPIX3 = 0 / Reference pixel
CRVAL3 = 10823.076 / Value at reference pixel on axis 3
CDELT3 = 0.017998 / Sampling along axis 3
CSYER3 = 0.017998 / Systematic Error along axis 3
```WCS fixesCarl SchafferCarl Schafferhttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/256GRIS header: RSUN_REF should be in meters2020-12-08T08:33:32ZVigeesh GangadharanGRIS header: RSUN_REF should be in metersIt seems like the RSUN_REF is in arcsec, but should be in meters ([Thomson et al 2010](https://ui.adsabs.harvard.edu/abs/2010A&A...515A..59T/abstract)).<br>It seems like the RSUN_REF is in arcsec, but should be in meters ([Thomson et al 2010](https://ui.adsabs.harvard.edu/abs/2010A&A...515A..59T/abstract)).<br>https://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/254Gris WCS: CTYPE should be HP instead of HG2021-02-11T17:34:08ZCarl SchafferGris WCS: CTYPE should be HP instead of HGExcempt from rocketchat:
> Vigeesh:
> Question about GRIS data header
> ```
> WCSNAME = 'Helioprojective Cartesian' / nan
> CTYPE1 = 'HGLN-TAN' / Type of coordinates along axis 1
> CUNIT1 = 'arcsec ' / Units alon...Excempt from rocketchat:
> Vigeesh:
> Question about GRIS data header
> ```
> WCSNAME = 'Helioprojective Cartesian' / nan
> CTYPE1 = 'HGLN-TAN' / Type of coordinates along axis 1
> CUNIT1 = 'arcsec ' / Units along axis 1
> CRPIX1 = 0 / Reference pixel
> CRVAL1 = -393.014 / Value at reference pixel on axis 1
> CDELT1 = 0.027174 / Sampling along axis 1
> ```
> HGLN-TAN according to Thompson et al refers to Stonyhurst heliographic longitude
> so, I'm a bit confused about why it is called "Helioprojective Cartesian"?
> also the CDELT1 is in HGLN-TAN or HPLN-TAN?
>
> schaffer
> 10:56 AM
> You're right, that is inconsistent. I believe CTYPE should be HPLT-TAN, at least that is what is being done under the hood. I'll open an issue and correct this in all files sometime in the near future.
* [x] fix code
* [x] re-format files
* [ ] re-upload files to archiveWCS fixeshttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/250mapgen: IQUV previews2020-10-16T09:49:51ZCarl Schaffermapgen: IQUV previewsAdd QUV previews to GRISAdd QUV previews to GRIShttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/248gris targets: redundant vocabulary2021-02-11T17:36:34ZCarl Schaffergris targets: redundant vocabulary![image](/uploads/5323c1dd8286fbba786a89f50886f007/image.png)
The targets specified in the headers and or db are not consistent. e.g. `Emerging flux Region` and `Emerging Flux Reg.` need to be consolidated.
Full consolidation includes...![image](/uploads/5323c1dd8286fbba786a89f50886f007/image.png)
The targets specified in the headers and or db are not consistent. e.g. `Emerging flux Region` and `Emerging Flux Reg.` need to be consolidated.
Full consolidation includes:
* [ ] Check where the tag names originate
* [ ] Decide on a consistent naming convention
* [ ] Open issues regarding enforcing and documenting said scheme
* [ ] Fix the names in all datasets, starting at L0 headers
* [ ] Fix the names in the corresponding observation entrieshttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/247gris run: Coord save from other runs2020-10-01T15:19:35ZCarl Schaffergris run: Coord save from other runsGrisRuns `coord_saves` property returns saves for other runs, this shouldn't happen.
![Selection_164](/uploads/f46e62d437aea9f49bf6dd63ea358011/Selection_164.png)GrisRuns `coord_saves` property returns saves for other runs, this shouldn't happen.
![Selection_164](/uploads/f46e62d437aea9f49bf6dd63ea358011/Selection_164.png)https://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/243translate header: don't run git info for every file2020-09-21T11:06:29ZCarl Schaffertranslate header: don't run git info for every filegit info is currently being run for every file during translation. this is unnecessary overheadgit info is currently being run for every file during translation. this is unnecessary overheadCarl SchafferCarl Schafferhttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/239mapgen: plot in HPC2020-10-16T09:52:20ZCarl Schaffermapgen: plot in HPCGenerate maps in helioprojective coordinates instead of pixel coords unse Sunpy Maps for thisGenerate maps in helioprojective coordinates instead of pixel coords unse Sunpy Maps for thishttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/218Gris: Some runs not translated2020-05-27T11:54:13ZCarl SchafferGris: Some runs not translatedSome runs do not seem to be fully translated:
![image](/uploads/847f0203e1fd5ad24816ffa21726e518/image.png)
List of the first split files of these runs:
gris_20140503_140502_l1p_012_001_0001.fits
gris_20140503_145531_l1p_015...Some runs do not seem to be fully translated:
![image](/uploads/847f0203e1fd5ad24816ffa21726e518/image.png)
List of the first split files of these runs:
gris_20140503_140502_l1p_012_001_0001.fits
gris_20140503_145531_l1p_015_001_0001.fits
gris_20140503_154906_l1p_018_001_0001.fits
gris_20140503_161857_l1p_020_001_0001.fits
gris_20140503_162943_l1p_021_001_0001.fits
gris_20140503_164102_l1p_022_001_0001.fits
gris_20140503_165223_l1p_023_001_0001.fits
gris_20140503_171735_l1p_026_001_0001.fits
gris_20140503_174110_l1p_027_001_0001.fits
gris_20150603_082644_l1p_004_001_0001.fits
gris_20150603_084246_l1p_005_001_0001.fits
gris_20150603_091312_l1p_006_001_0001.fits
gris_20150603_095403_l1p_008_001_0001.fits
gris_20150603_102339_l1p_009_001_0001.fits
gris_20160602_075844_l1p_001_001_0001.fits
gris_20160602_081620_l1p_002_001_0001.fits
gris_20160602_095847_l1p_006_001_0001.fits
gris_20160602_101825_l1p_007_001_0001.fits
gris_20170616_092551_l1p_005_001_0001.fits
gris_20170616_103511_l1p_007_001_0001.fits
gris_20180504_155639_l1p_016_001_0001.fits
gris_20180504_155905_l1p_017_001_0001.fits
gris_20180504_163932_l1p_020_001_0001.fits
gris_20180504_170742_l1p_021_001_0001.fitshttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/203GRIS: Cross correlation file structure2019-12-12T09:25:18ZCarl SchafferGRIS: Cross correlation file structureThere are different structures for the cross correlation files. sometimes `slit_orientation` is used, sometimes `slit_angle` this should be made uniform.There are different structures for the cross correlation files. sometimes `slit_orientation` is used, sometimes `slit_angle` this should be made uniform.GRIS CoordinatesCarl SchafferCarl Schafferhttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/201GrisRun bounding Box2019-12-05T10:44:54ZCarl SchafferGrisRun bounding BoxThe bounding box for gris run is calculated from the centers of the slits instead of the edges of the slits.The bounding box for gris run is calculated from the centers of the slits instead of the edges of the slits.GRIS Coordinateshttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/198GRISFitsFile: Re-think Coordinate access2019-12-05T10:44:57ZCarl SchafferGRISFitsFile: Re-think Coordinate accessRe think coordinate access:
plotting of slit should show:
* coords from wcs
* coords from slitpos and slitorieRe think coordinate access:
plotting of slit should show:
* coords from wcs
* coords from slitpos and slitorieGRIS Coordinateshttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/196GRIS importer: add masks2020-04-09T08:01:52ZCarl SchafferGRIS importer: add maskshttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/195GRIS Location: Indicate uncertainty2019-12-03T17:16:58ZCarl SchafferGRIS Location: Indicate uncertaintyIndicate the uncertainty of the measurements in the location plots.Indicate the uncertainty of the measurements in the location plots.GRIS CoordinatesCarl SchafferCarl Schafferhttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/194GRIS Importer: New Map Previews2020-02-26T14:41:17ZCarl SchafferGRIS Importer: New Map PreviewsNew Map previews have been implemented, but so far, the importer doesn't use them by default.New Map previews have been implemented, but so far, the importer doesn't use them by default.https://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/186GRIS Coordinates: Solar Rotation2021-05-11T08:31:58ZCarl SchafferGRIS Coordinates: Solar RotationWhen using the updated GRIS data, Morten and Adur were not 100 percent sure whether the coordinates specified in the WCS keywords for the slit kws were correct. Definitely check this and write down some evidence.
Also check:
- Blue and...When using the updated GRIS data, Morten and Adur were not 100 percent sure whether the coordinates specified in the WCS keywords for the slit kws were correct. Definitely check this and write down some evidence.
Also check:
- Blue and Red observations
- Multimap observations
- Sit and Stare
- Polarimetric observations
Steps:
1. Collect testing data
2. Implement plotting of the coverage over a concurrent HMI Image
3. Compare with image content
4. Document results somewhere, eg here on gitlabhttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/138GrisFitsFile slit coords full slit instead of center2019-12-03T17:17:04ZCarl SchafferGrisFitsFile slit coords full slit instead of center# Bug Report
## Summary
`slit_coords` method provides center instead of full slit coordinate array
## Steps to Reproduce
get an instance of GrisFitsFile and access the `slit_coords` method
## Expected Results
array of coords
## Actual R...# Bug Report
## Summary
`slit_coords` method provides center instead of full slit coordinate array
## Steps to Reproduce
get an instance of GrisFitsFile and access the `slit_coords` method
## Expected Results
array of coords
## Actual Results
single pointGRIS CoordinatesCarl SchafferCarl Schafferhttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/110importer gris: error logging not working2020-04-09T08:03:16ZCarl Schafferimporter gris: error logging not workingLogging does not seem to work correctly... Errors occurr but the error log files are emptyLogging does not seem to work correctly... Errors occurr but the error log files are empty