kis_tools issueshttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues2021-09-30T10:30:06Zhttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/286Add interface to grisplot2021-09-30T10:30:06ZCarl SchafferAdd interface to grisplotthe grisplot utility in the bin folder is undocumented even though it's pretty useful. Add a cleaner interface based on the kis_tools interface structure and add documentation.the grisplot utility in the bin folder is undocumented even though it's pretty useful. Add a cleaner interface based on the kis_tools interface structure and add documentation.https://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/287Add interface to gristagger2021-09-30T10:30:05ZCarl SchafferAdd interface to gristaggerthe gristagger utility in the bin folder is undocumented even though it's pretty useful. Add a cleaner interface based on the kis_tools interface structure and add documentation.the gristagger utility in the bin folder is undocumented even though it's pretty useful. Add a cleaner interface based on the kis_tools interface structure and add documentation.https://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/257CTYPE inconsistency in header for data in spectroscopic mode2021-02-11T17:33:36ZVigeesh GangadharanCTYPE inconsistency in header for data in spectroscopic modeFor dataset in spectroscopic mode, the first axis seems to be always wavelength.<br>
But this is not consistent with the CTYPE-_i_ keywords later.
e.g.
```
SIMPLE = T / conforms to FITS standard ...For dataset in spectroscopic mode, the first axis seems to be always wavelength.<br>
But this is not consistent with the CTYPE-_i_ keywords later.
e.g.
```
SIMPLE = T / conforms to FITS standard
BITPIX = 32 / array data type
NAXIS = 3 / number of array dimensions
NAXIS1 = 1010 / Length of data axis 1
NAXIS2 = 484 / Length of data axis 2
NAXIS3 = 1 / Length of data axis 3
FILENAME= 'gris_20160613_120408_l1s_008_120_0029.fits' / Name of file
EXTNAME = '20160613_008_120_0029' / Unique HDU name
POINT_ID= '20160613_008' / Unique (re-)pointing ID
OBS_TRGT= 'Sunspot(s)' / Observation Target
WCSNAME = 'Helioprojective Cartesian' / nan
CTYPE1 = 'HGLN-TAN' / Type of coordinates along axis 1
CUNIT1 = 'arcsec ' / Units along axis 1
CRPIX1 = 0 / Reference pixel
CRVAL1 = 297.671 / Value at reference pixel on axis 1
CDELT1 = 0.080792 / Sampling along axis 1
CSYER1 = 1900 / Systematic Error along axis 1
CTYPE2 = 'HGLT-TAN' / Type of coordinates along axis 2
CUNIT2 = 'arcsec ' / Units along axis 2
CRPIX2 = 0 / Reference pixel
CRVAL2 = 408.258 / Value at reference pixel on axis 2
CDELT2 = 0.080792 / Sampling along axis 2
CSYER2 = 1900 / Systematic Error along axis 2
CTYPE3 = 'WAVE ' / Type of coordinates along axis 3
CUNIT3 = 'Angstrom' / Units along axis 3
CRPIX3 = 0 / Reference pixel
CRVAL3 = 10823.076 / Value at reference pixel on axis 3
CDELT3 = 0.017998 / Sampling along axis 3
CSYER3 = 0.017998 / Systematic Error along axis 3
```WCS fixesCarl SchafferCarl Schafferhttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/73GrisArchive Dataframe does not create runs if no level1 data is present2020-12-22T13:33:28ZCarl SchafferGrisArchive Dataframe does not create runs if no level1 data is presentbug, problematic when working on Lindner databug, problematic when working on Lindner dataremove importer utilitieshttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/259GRIS Coordinates without cross correlation2021-02-11T17:32:42ZCarl SchafferGRIS Coordinates without cross correlation
In general we want to have a full cross correlation of coordinates fro GRIS maps. This is the preferred method of getting coordinates for WCS keywords. Back when we did this, we assumed SLITPOS_X and SLITPOS_Y to give coordinates in a ...
In general we want to have a full cross correlation of coordinates fro GRIS maps. This is the preferred method of getting coordinates for WCS keywords. Back when we did this, we assumed SLITPOS_X and SLITPOS_Y to give coordinates in a system that is aligned with the solar axis and for that matter with the HMI system.
Looking at the location guesses from the Mercury transit of last year, it seems very likely, that there is an additional rotation between the systems that we don't account for. This would also affect our uncertainty estimates for non-correlated files. See https://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/199
![transit](/uploads/9e4bb8c70cef34cb3b68c6fa0964b603/transit.gif)WCS fixeshttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/203GRIS: Cross correlation file structure2019-12-12T09:25:18ZCarl SchafferGRIS: Cross correlation file structureThere are different structures for the cross correlation files. sometimes `slit_orientation` is used, sometimes `slit_angle` this should be made uniform.There are different structures for the cross correlation files. sometimes `slit_orientation` is used, sometimes `slit_angle` this should be made uniform.GRIS CoordinatesCarl SchafferCarl Schafferhttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/297GRIS data is flipped depending on step-angle2022-04-21T10:46:49ZCarl SchafferGRIS data is flipped depending on step-angleDepending on how the slit data is scanned, images are flipped w.r.t. HMI.
We should consider serving flipped data to the end-users instead of what we're doing right now.
* [ ] Check whether this is already done somewhere
* [ ] Evaluat...Depending on how the slit data is scanned, images are flipped w.r.t. HMI.
We should consider serving flipped data to the end-users instead of what we're doing right now.
* [ ] Check whether this is already done somewhere
* [ ] Evaluate how much effort a fix would be
* [ ] decide on actionCarl SchafferCarl Schaffer2021-11-30https://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/198GRISFitsFile: Re-think Coordinate access2019-12-05T10:44:57ZCarl SchafferGRISFitsFile: Re-think Coordinate accessRe think coordinate access:
plotting of slit should show:
* coords from wcs
* coords from slitpos and slitorieRe think coordinate access:
plotting of slit should show:
* coords from wcs
* coords from slitpos and slitorieGRIS Coordinateshttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/138GrisFitsFile slit coords full slit instead of center2019-12-03T17:17:04ZCarl SchafferGrisFitsFile slit coords full slit instead of center# Bug Report
## Summary
`slit_coords` method provides center instead of full slit coordinate array
## Steps to Reproduce
get an instance of GrisFitsFile and access the `slit_coords` method
## Expected Results
array of coords
## Actual R...# Bug Report
## Summary
`slit_coords` method provides center instead of full slit coordinate array
## Steps to Reproduce
get an instance of GrisFitsFile and access the `slit_coords` method
## Expected Results
array of coords
## Actual Results
single pointGRIS CoordinatesCarl SchafferCarl Schafferhttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/279gris header: AO_MODES=02021-10-11T16:01:08ZCarl Schaffergris header: AO_MODES=0Corrected modes by ao are set to 0 in the sample file I sent to Oslo, we should check where that Value comes from and whether it's correct. If we don't know, we should probably switch to NAN or something similar.Corrected modes by ao are set to 0 in the sample file I sent to Oslo, we should check where that Value comes from and whether it's correct. If we don't know, we should probably switch to NAN or something similar.https://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/258GRIS Header Observer Metadata2021-02-23T10:01:48ZCarl SchafferGRIS Header Observer Metadata![Clipboard_-_November_26__2020_2_54_PM](/uploads/100ec7c094c94884841d2cfe7fccea67/Clipboard_-_November_26__2020_2_54_PM.png)
We should add the HGLN_obs and dsun_ref keywords to the header to silence the astropy warning![Clipboard_-_November_26__2020_2_54_PM](/uploads/100ec7c094c94884841d2cfe7fccea67/Clipboard_-_November_26__2020_2_54_PM.png)
We should add the HGLN_obs and dsun_ref keywords to the header to silence the astropy warningWCS fixesCarl SchafferCarl Schafferhttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/256GRIS header: RSUN_REF should be in meters2020-12-08T08:33:32ZVigeesh GangadharanGRIS header: RSUN_REF should be in metersIt seems like the RSUN_REF is in arcsec, but should be in meters ([Thomson et al 2010](https://ui.adsabs.harvard.edu/abs/2010A&A...515A..59T/abstract)).<br>It seems like the RSUN_REF is in arcsec, but should be in meters ([Thomson et al 2010](https://ui.adsabs.harvard.edu/abs/2010A&A...515A..59T/abstract)).<br>https://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/280gris headers changes2021-10-11T16:36:09ZCarl Schaffergris headers changes* [x] Origin: KIS
* [x] Timeunit for exposure times/ change time values to seconds* [x] Origin: KIS
* [x] Timeunit for exposure times/ change time values to secondshttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/196GRIS importer: add masks2020-04-09T08:01:52ZCarl SchafferGRIS importer: add maskshttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/194GRIS Importer: New Map Previews2020-02-26T14:41:17ZCarl SchafferGRIS Importer: New Map PreviewsNew Map previews have been implemented, but so far, the importer doesn't use them by default.New Map previews have been implemented, but so far, the importer doesn't use them by default.https://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/195GRIS Location: Indicate uncertainty2019-12-03T17:16:58ZCarl SchafferGRIS Location: Indicate uncertaintyIndicate the uncertainty of the measurements in the location plots.Indicate the uncertainty of the measurements in the location plots.GRIS CoordinatesCarl SchafferCarl Schafferhttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/188Gris PhD Embargos2020-05-12T09:46:26ZCarl SchafferGris PhD EmbargosWrite list of observers per day to NBG, she will check which dates should be embargoed.Write list of observers per day to NBG, she will check which dates should be embargoed.Demleitner VisitCarl SchafferCarl Schaffer2020-05-11https://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/201GrisRun bounding Box2019-12-05T10:44:54ZCarl SchafferGrisRun bounding BoxThe bounding box for gris run is calculated from the centers of the slits instead of the edges of the slits.The bounding box for gris run is calculated from the centers of the slits instead of the edges of the slits.GRIS Coordinateshttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/247gris run: Coord save from other runs2020-10-01T15:19:35ZCarl Schaffergris run: Coord save from other runsGrisRuns `coord_saves` property returns saves for other runs, this shouldn't happen.
![Selection_164](/uploads/f46e62d437aea9f49bf6dd63ea358011/Selection_164.png)GrisRuns `coord_saves` property returns saves for other runs, this shouldn't happen.
![Selection_164](/uploads/f46e62d437aea9f49bf6dd63ea358011/Selection_164.png)https://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/69Gris Run was aborted not robust2020-06-04T12:23:19ZCarl SchafferGris Run was aborted not robustif first map was aborted, is doesnt workif first map was aborted, is doesnt workStreamlining Codebase