kis_tools issueshttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues2020-12-11T08:29:51Zhttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/265dev needs pytest-cov2020-12-11T08:29:51ZCarl Schafferdev needs pytest-covadd pytest cov to a developer extra installadd pytest cov to a developer extra installhttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/249headers: EXPTIME2020-12-10T12:11:27ZCarl Schafferheaders: EXPTIME`EXPTIME`is required by solarsoft but strongly discouraged by SOLARNET
discussion:
> hola!
> is it true that we do not have an entry for 'exposure time' in the header metadata?
>
> 9:22 AM
> morning 🙂
> no, we have that
>
> 9:23 AM
>...`EXPTIME`is required by solarsoft but strongly discouraged by SOLARNET
discussion:
> hola!
> is it true that we do not have an entry for 'exposure time' in the header metadata?
>
> 9:22 AM
> morning 🙂
> no, we have that
>
> 9:23 AM
> ok. aparently Lucia mentioned in the questionaire that we do not have it
>
> 9:25 AM
> what we don't have is the
> EXPTIME
> keyword. SOLARNET discourqages using it, as it is unclear whether it means single frame exposure or total exposure time
> what we do instead for GRIS (as recomended by solarnet) :
> ```
> XPOSURE = 300.0 / [ms] Accumulated exposure time
> TEXPOSUR= 100.0 / [ms] Single-exposure time
> NSUMEXP = 3 / Number of summed exposures
> ```
>
> i think for GSJC we added the EXPTIME keyword specifically for lucia
>
> 9:28 AM
> ok.
> i believe what LK meant is that 'exptime' is/was widely used and i guess SolarSoft requires it.
> When Morten was around there was some agreement with LK to include duplicates of some keywords.
> I bet 'exptime' should be one of them..
>
> 9:28 AM
> yes it was
>
> 9:28 AM
> exactly
>
> schaffer 9:26 AM
> i think for GSJC we added the EXPTIME keyword specifically for lucia
> 9:29 AM
> is there a specification or definition document on which keywords solarsoft expects?
> we could try to check whether it conflicts with SOLARNET once we start nailing down the standards
>
>
> 9:31 AM
> i don't know. should be checked.
> it is also true that SOLARNET should clarify how to deal with this issue..WCS fixeshttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/264location plot image size2020-12-08T12:32:10ZCarl Schafferlocation plot image sizeLocation plot images are unnecessarily large and take very long to load with a poor internet connectionLocation plot images are unnecessarily large and take very long to load with a poor internet connectionhttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/256GRIS header: RSUN_REF should be in meters2020-12-08T08:33:32ZVigeesh GangadharanGRIS header: RSUN_REF should be in metersIt seems like the RSUN_REF is in arcsec, but should be in meters ([Thomson et al 2010](https://ui.adsabs.harvard.edu/abs/2010A&A...515A..59T/abstract)).<br>It seems like the RSUN_REF is in arcsec, but should be in meters ([Thomson et al 2010](https://ui.adsabs.harvard.edu/abs/2010A&A...515A..59T/abstract)).<br>https://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/219OBSGEO Coordinates2020-11-27T13:47:26ZCarl SchafferOBSGEO CoordinatesOBSGEO coordinates in FITS header do not point to OT, but to Roque de los muchachos. This means ALL fits files for GRIS are invalid (at least here)
![image](/uploads/8aa28cc99b1f10f7d042189603a651bc/image.png)
![image](/uploads/e30bba9...OBSGEO coordinates in FITS header do not point to OT, but to Roque de los muchachos. This means ALL fits files for GRIS are invalid (at least here)
![image](/uploads/8aa28cc99b1f10f7d042189603a651bc/image.png)
![image](/uploads/e30bba90093adfb7694fea4986cc1efb/image.png)reimport with kharonhttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/199GRIS Coordinates: Uncertainty estimation2020-11-27T12:39:32ZCarl SchafferGRIS Coordinates: Uncertainty estimationGo over runs with cross correlations and check how large the discrepancy between the telescope's coordinates and the cross_correlated coordinates are.Go over runs with cross correlations and check how large the discrepancy between the telescope's coordinates and the cross_correlated coordinates are.Carl SchafferCarl Schafferhttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/253location plot: package to nice function2020-11-18T14:45:47ZCarl Schafferlocation plot: package to nice functionThere is too much logic in the gris_locplot script in the bin/ folder. Move that to a function.There is too much logic in the gris_locplot script in the bin/ folder. Move that to a function.GRIS Pipeline Automationhttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/252add documentation to calib file parsing2020-10-26T17:34:52ZCarl Schafferadd documentation to calib file parsingCarl SchafferCarl Schafferhttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/120CI add testing as CI step2020-10-16T09:52:32ZCarl SchafferCI add testing as CI stephttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/239mapgen: plot in HPC2020-10-16T09:52:20ZCarl Schaffermapgen: plot in HPCGenerate maps in helioprojective coordinates instead of pixel coords unse Sunpy Maps for thisGenerate maps in helioprojective coordinates instead of pixel coords unse Sunpy Maps for thishttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/247gris run: Coord save from other runs2020-10-01T15:19:35ZCarl Schaffergris run: Coord save from other runsGrisRuns `coord_saves` property returns saves for other runs, this shouldn't happen.
![Selection_164](/uploads/f46e62d437aea9f49bf6dd63ea358011/Selection_164.png)GrisRuns `coord_saves` property returns saves for other runs, this shouldn't happen.
![Selection_164](/uploads/f46e62d437aea9f49bf6dd63ea358011/Selection_164.png)https://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/224add logger2020-09-28T11:01:38ZCarl Schafferadd loggerremove importer utilitieshttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/139add md manual for tests folder2020-09-24T14:00:00ZCarl Schafferadd md manual for tests folderremove importer utilitiesCarl SchafferCarl Schafferhttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/209Documentation: Update README after restructure2020-09-24T14:00:00ZCarl SchafferDocumentation: Update README after restructureremove importer utilitiesCarl SchafferCarl Schafferhttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/225update contributing2020-09-24T13:59:59ZCarl Schafferupdate contributingUpdate DocumentationUpdate Documentationremove importer utilitiesCarl SchafferCarl Schafferhttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/241Move Settings module2020-09-23T15:37:34ZCarl SchafferMove Settings moduleMove the settings module to the generic folderMove the settings module to the generic folderremove importer utilitiesCarl SchafferCarl Schafferhttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/243translate header: don't run git info for every file2020-09-21T11:06:29ZCarl Schaffertranslate header: don't run git info for every filegit info is currently being run for every file during translation. this is unnecessary overheadgit info is currently being run for every file during translation. this is unnecessary overheadCarl SchafferCarl Schafferhttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/242kis_tools git info2020-09-21T11:06:28ZCarl Schafferkis_tools git infoIf KIS tools is installed locally, it is impossible to update git_info dynamically. I need to either remove it or check it in at each commit.
Even better: add the generation to the install script and add it to MANIFEST.inIf KIS tools is installed locally, it is impossible to update git_info dynamically. I need to either remove it or check it in at each commit.
Even better: add the generation to the install script and add it to MANIFEST.inCarl SchafferCarl Schafferhttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/183Refactor: Generic interface2020-07-17T14:31:30ZCarl SchafferRefactor: Generic interfaceuse generic interface for all importers and check that it is used by all. also add this info to any readmes concerning addition of new instruments/development of new importersuse generic interface for all importers and check that it is used by all. also add this info to any readmes concerning addition of new instruments/development of new importersremove importer utilitieshttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/214switch git info in mongo clients to package version2020-07-17T14:31:29ZCarl Schafferswitch git info in mongo clients to package versionSemantic versioning makes more sense than stupidly adding the git revision. Also installing via pip breaks the git info utility.Semantic versioning makes more sense than stupidly adding the git revision. Also installing via pip breaks the git info utility.remove importer utilities