kis_tools issueshttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues2020-09-28T11:01:38Zhttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/224add logger2020-09-28T11:01:38ZCarl Schafferadd loggerremove importer utilitieshttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/223headers: Btype for spec runs2020-04-22T13:45:53ZCarl Schafferheaders: Btype for spec runs`Btype` shouldn't be `Stokes Spectra along slit` for spectroscopic run![Selection_052](/uploads/bfac1381b2ab7d47c88f44d1de0d7a26/Selection_052.png)`Btype` shouldn't be `Stokes Spectra along slit` for spectroscopic run![Selection_052](/uploads/bfac1381b2ab7d47c88f44d1de0d7a26/Selection_052.png)Carl SchafferCarl Schafferhttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/222remove field list for observation descriptions2020-07-16T10:20:26ZCarl Schafferremove field list for observation descriptionsRlated to https://gitlab.leibniz-kis.de/sdc/sda_kharon/merge_requests/29Rlated to https://gitlab.leibniz-kis.de/sdc/sda_kharon/merge_requests/29remove importer utilitieshttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/221mime type for idl save files2020-04-15T15:08:07ZCarl Schaffermime type for idl save filesmime type for idl save files does not work (value in db is null)mime type for idl save files does not work (value in db is null)https://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/220Data Problem: Lars and Gris Logfiles have same name2020-04-09T07:43:37ZCarl SchafferData Problem: Lars and Gris Logfiles have same nameLogfiles from GRIS and LARS are not distinguishable by filename. This might lead to problems down the road, as the importer assumes files to be associable to an instrument by their name.
The Problem is not really severe, as LARS logfil...Logfiles from GRIS and LARS are not distinguishable by filename. This might lead to problems down the road, as the importer assumes files to be associable to an instrument by their name.
The Problem is not really severe, as LARS logfiles are currently generated on the fly anyway, but this needs to be taken into account when reimporting LARS data.https://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/219OBSGEO Coordinates2020-11-27T13:47:26ZCarl SchafferOBSGEO CoordinatesOBSGEO coordinates in FITS header do not point to OT, but to Roque de los muchachos. This means ALL fits files for GRIS are invalid (at least here)
![image](/uploads/8aa28cc99b1f10f7d042189603a651bc/image.png)
![image](/uploads/e30bba9...OBSGEO coordinates in FITS header do not point to OT, but to Roque de los muchachos. This means ALL fits files for GRIS are invalid (at least here)
![image](/uploads/8aa28cc99b1f10f7d042189603a651bc/image.png)
![image](/uploads/e30bba90093adfb7694fea4986cc1efb/image.png)reimport with kharonhttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/218Gris: Some runs not translated2020-05-27T11:54:13ZCarl SchafferGris: Some runs not translatedSome runs do not seem to be fully translated:
![image](/uploads/847f0203e1fd5ad24816ffa21726e518/image.png)
List of the first split files of these runs:
gris_20140503_140502_l1p_012_001_0001.fits
gris_20140503_145531_l1p_015...Some runs do not seem to be fully translated:
![image](/uploads/847f0203e1fd5ad24816ffa21726e518/image.png)
List of the first split files of these runs:
gris_20140503_140502_l1p_012_001_0001.fits
gris_20140503_145531_l1p_015_001_0001.fits
gris_20140503_154906_l1p_018_001_0001.fits
gris_20140503_161857_l1p_020_001_0001.fits
gris_20140503_162943_l1p_021_001_0001.fits
gris_20140503_164102_l1p_022_001_0001.fits
gris_20140503_165223_l1p_023_001_0001.fits
gris_20140503_171735_l1p_026_001_0001.fits
gris_20140503_174110_l1p_027_001_0001.fits
gris_20150603_082644_l1p_004_001_0001.fits
gris_20150603_084246_l1p_005_001_0001.fits
gris_20150603_091312_l1p_006_001_0001.fits
gris_20150603_095403_l1p_008_001_0001.fits
gris_20150603_102339_l1p_009_001_0001.fits
gris_20160602_075844_l1p_001_001_0001.fits
gris_20160602_081620_l1p_002_001_0001.fits
gris_20160602_095847_l1p_006_001_0001.fits
gris_20160602_101825_l1p_007_001_0001.fits
gris_20170616_092551_l1p_005_001_0001.fits
gris_20170616_103511_l1p_007_001_0001.fits
gris_20180504_155639_l1p_016_001_0001.fits
gris_20180504_155905_l1p_017_001_0001.fits
gris_20180504_163932_l1p_020_001_0001.fits
gris_20180504_170742_l1p_021_001_0001.fitshttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/217Interface: Consistent strategy2020-02-06T17:42:30ZCarl SchafferInterface: Consistent strategyDefine a consistent strategy for naming functions in the interface submodule. Eg functions that add options should have a name, functions that add arguments should have a name and functions taht add entire interfaces should have a name. ...Define a consistent strategy for naming functions in the interface submodule. Eg functions that add options should have a name, functions that add arguments should have a name and functions taht add entire interfaces should have a name.
Also standardize the documentation here.
* [x] Adapt usages of the interface e.g. chroquesthttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/215headers ucds in btype etc2020-02-26T14:46:09ZCarl Schafferheaders ucds in btype etchttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/214switch git info in mongo clients to package version2020-07-17T14:31:29ZCarl Schafferswitch git info in mongo clients to package versionSemantic versioning makes more sense than stupidly adding the git revision. Also installing via pip breaks the git info utility.Semantic versioning makes more sense than stupidly adding the git revision. Also installing via pip breaks the git info utility.remove importer utilitieshttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/213bug: duplicate checking tests fail2020-04-21T16:33:51ZCarl Schafferbug: duplicate checking tests fail# Bug Report
## Summary
test_high_level.py/test_import fails
## Steps to Reproduce
rn the test
## Expected Results
to work
## Actual Results
fails
Something is definetely messed up here... i suspect that it has to do with the query ...# Bug Report
## Summary
test_high_level.py/test_import fails
## Steps to Reproduce
rn the test
## Expected Results
to work
## Actual Results
fails
Something is definetely messed up here... i suspect that it has to do with the query used to find duplicate candidates in the database. I need to investigate how this checking is done in detail and for which file types it fails.
![Selection_120](/uploads/4a6b2dc33c3924ca76e4364b38b040a5/Selection_120.png)https://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/212calc_footprint: fails with BBI header2020-01-31T16:32:23ZCarl Schaffercalc_footprint: fails with BBI header# Bug Report
## Summary
calc_footprint fails with a bbi header because the pixel indices are set with a static lenght
## Steps to Reproduce
run unittests in tests/test_util.py
## Expected Results
prduce a correct footprint
## Actual...# Bug Report
## Summary
calc_footprint fails with a bbi header because the pixel indices are set with a static lenght
## Steps to Reproduce
run unittests in tests/test_util.py
## Expected Results
prduce a correct footprint
## Actual Results
ValueError
![Selection_119](/uploads/b4e0afd2a120b19d32d9df7ccf7e99ae/Selection_119.png)https://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/211translate header on fresh install fails with error due to missing WCSGenerator2020-02-26T14:34:11ZCarl Schaffertranslate header on fresh install fails with error due to missing WCSGeneratorhttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/210install needs to add header templates2020-02-26T14:36:35ZCarl Schafferinstall needs to add header templatesSome files are not copied to the sit package when installing via pip, this needs to be fixedSome files are not copied to the sit package when installing via pip, this needs to be fixedhttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/209Documentation: Update README after restructure2020-09-24T14:00:00ZCarl SchafferDocumentation: Update README after restructureremove importer utilitiesCarl SchafferCarl Schafferhttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/208_coords_from_wcs to generic function2020-01-30T15:14:19ZTaras Yakobchuk_coords_from_wcs to generic function_coords_from_wcs from GrisFitsFile should be a separate function_coords_from_wcs from GrisFitsFile should be a separate functionCarl SchafferCarl Schafferhttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/207module: header tools2020-07-16T10:14:48ZCarl Schaffermodule: header toolsWrite a module that provides header checking from templates as well as well as eventually header generation for different instruments.
Should have different tests such as:
* [ ] Compare planned list of keywords to actual list of keywo...Write a module that provides header checking from templates as well as well as eventually header generation for different instruments.
Should have different tests such as:
* [ ] Compare planned list of keywords to actual list of keywords
* [ ] Check typing of values
* [ ] Check FITS comment lenghts in templates
* [ ] Host definitive templates for different instrumentshttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/206Interface definition for rewrite2020-02-26T14:37:00ZCarl SchafferInterface definition for rewritehttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/205ChroTel: Automatic Importer2020-02-28T11:19:16ZCarl SchafferChroTel: Automatic ImporterSet up a system that imports new chrotel data periodically.
e.g. cron job that runs every night, check newest chrotel folder from last run, import and save info on most recent folder
*Might run into race condition if files are being co...Set up a system that imports new chrotel data periodically.
e.g. cron job that runs every night, check newest chrotel folder from last run, import and save info on most recent folder
*Might run into race condition if files are being copied while the importer is running*https://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/204Standard Scheme for Collection Connections2020-04-09T08:03:00ZCarl SchafferStandard Scheme for Collection ConnectionsIn the discussion with Taras, it became clear that having a connection between collections that allows deduction of the parent collection with only the connection tag name would be great.
For now this only means that `obs_id` should be...In the discussion with Taras, it became clear that having a connection between collections that allows deduction of the parent collection with only the connection tag name would be great.
For now this only means that `obs_id` should be replaced with `observations_id` wherever it occurs.
This is definitely part of a larger change, but for now, changing this key
* [ ] on the importers
and
* [ ] on the website
should be sufficient.