kis_tools issueshttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues2020-07-16T10:24:46Zhttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/85tagger add description of map2020-07-16T10:24:46ZCarl Schaffertagger add description of mapmap length (pixel size in particular)map length (pixel size in particular)https://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/162bbi: add docstrings2020-07-16T10:08:01ZCarl Schafferbbi: add docstringsBBI Publicationhttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/168IVOA: Calibration Level Mismatch2019-09-02T10:04:57ZCarl SchafferIVOA: Calibration Level MismatchA standard for Data level definitions is needed. IVOA provides a definition they want to see used, however, this definition does not match up with the data Level usage commonly used at KIS.
# Our Definitions
The definitions we use curre...A standard for Data level definitions is needed. IVOA provides a definition they want to see used, however, this definition does not match up with the data Level usage commonly used at KIS.
# Our Definitions
The definitions we use currently are (to the best of my knowledge):
0. Raw Data
1. Calibrated/ Reconstructed Data
2. Scientific information such as Dopplergrams
3. Inversions
# Definitions of Calibration Levels by IVOA
![Selection_063](/uploads/018dace8f7cf2365b5eb08aa8b6b6b10/Selection_063.png)
# Solarnet on Data Levels
>The concept of "data level" is often used to label data with a particular degree of processing,
from raw data up to complex data products.
However, definitions of data levels are extremely instrument-/mission-/pipeline-dependent, and
not very useful in terms of explaining what processing has been applied. This concept is useful,
however, to ensure that files with different processing level have unique file names. For this
reason, the keyword
LEVEL
may be used, as a string value to capture sub-levels such as quick-
look versions.
# Examples
![Selection_062](/uploads/58d1b2d7076f50afba80a7daf0d7d8d4/Selection_062.png)https://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/176LARS: Different FOV sizes2020-07-16T10:22:43ZCarl SchafferLARS: Different FOV sizes![image](/uploads/fde7268878b278a13098996e61979cce/image.png)
Are the different FOV sizes accounted for in the observation descriptions?![image](/uploads/fde7268878b278a13098996e61979cce/image.png)
Are the different FOV sizes accounted for in the observation descriptions?https://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/177BBI Preview: Add full Obs identifier2020-07-16T10:06:32ZCarl SchafferBBI Preview: Add full Obs identifierAdd observation identifier to reco previewsAdd observation identifier to reco previewsBBI Publicationhttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/186GRIS Coordinates: Solar Rotation2021-05-11T08:31:58ZCarl SchafferGRIS Coordinates: Solar RotationWhen using the updated GRIS data, Morten and Adur were not 100 percent sure whether the coordinates specified in the WCS keywords for the slit kws were correct. Definitely check this and write down some evidence.
Also check:
- Blue and...When using the updated GRIS data, Morten and Adur were not 100 percent sure whether the coordinates specified in the WCS keywords for the slit kws were correct. Definitely check this and write down some evidence.
Also check:
- Blue and Red observations
- Multimap observations
- Sit and Stare
- Polarimetric observations
Steps:
1. Collect testing data
2. Implement plotting of the coverage over a concurrent HMI Image
3. Compare with image content
4. Document results somewhere, eg here on gitlabhttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/193BBI: extname needs incremental file number2020-07-16T10:07:01ZCarl SchafferBBI: extname needs incremental file numberExtname needs to have an incremented file number so that it is unique within the pointing runExtname needs to have an incremented file number so that it is unique within the pointing runBBI Publicationhttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/216coordinate validation: check with HEK and HFC2020-07-16T10:51:31ZCarl Schaffercoordinate validation: check with HEK and HFCChek whether our coordinates line up with common feature cataloguesChek whether our coordinates line up with common feature catalogueshttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/244gris plotting tools fails if no display is set2020-09-24T13:57:31ZCarl Schaffergris plotting tools fails if no display is set![image](/uploads/7057d1bcff22c6bc6d726cfd921f1ebb/image.png)![image](/uploads/7057d1bcff22c6bc6d726cfd921f1ebb/image.png)https://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/246BBI observation sorting2020-09-25T09:12:15ZCarl SchafferBBI observation sortingProof of concept and first runs has been done, production code isn't readyProof of concept and first runs has been done, production code isn't readyhttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/248gris targets: redundant vocabulary2021-02-11T17:36:34ZCarl Schaffergris targets: redundant vocabulary![image](/uploads/5323c1dd8286fbba786a89f50886f007/image.png)
The targets specified in the headers and or db are not consistent. e.g. `Emerging flux Region` and `Emerging Flux Reg.` need to be consolidated.
Full consolidation includes...![image](/uploads/5323c1dd8286fbba786a89f50886f007/image.png)
The targets specified in the headers and or db are not consistent. e.g. `Emerging flux Region` and `Emerging Flux Reg.` need to be consolidated.
Full consolidation includes:
* [ ] Check where the tag names originate
* [ ] Decide on a consistent naming convention
* [ ] Open issues regarding enforcing and documenting said scheme
* [ ] Fix the names in all datasets, starting at L0 headers
* [ ] Fix the names in the corresponding observation entrieshttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/250mapgen: IQUV previews2020-10-16T09:49:51ZCarl Schaffermapgen: IQUV previewsAdd QUV previews to GRISAdd QUV previews to GRIShttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/251gitlab pages documentation2020-10-23T07:30:20ZCarl Schaffergitlab pages documentationAdd automatically built documentation.
CI Setup and basic functionality is contained in the [docs branch](https://gitlab.leibniz-kis.de/sdc/kis_tools/-/tree/docs)
Things to take care of:
* [ ] think a bout strategy when the push shoul...Add automatically built documentation.
CI Setup and basic functionality is contained in the [docs branch](https://gitlab.leibniz-kis.de/sdc/kis_tools/-/tree/docs)
Things to take care of:
* [ ] think a bout strategy when the push should ocurr and when the documentation should be built (`only` section in gitlab ci)
* [ ] use common format for docstrings, check using tool
* [ ] Add structure in `.rst`fileshttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/261Feature Request: orientation info in preview images2020-12-01T12:37:42ZVigeesh GangadharanFeature Request: orientation info in preview imagesIt would be informative to have an arrow (e.g. solar North-pointing) over-layed on the preview maps, to give an idea about the orientation of the slit.It would be informative to have an arrow (e.g. solar North-pointing) over-layed on the preview maps, to give an idea about the orientation of the slit.https://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/266gitinfo breaks pip install2021-02-22T17:05:57ZCarl Schaffergitinfo breaks pip install# Bug Report
## Summary
pip install form repo fails
## Steps to Reproduce
```
pip install git+http://gitlab.leibniz-kis.de/sdc/kis_tools
```
or
```bash
git clone http://gitlab.leibniz-kis.de/sdc/kis_tools
cd kis_tools
pip install .
``...# Bug Report
## Summary
pip install form repo fails
## Steps to Reproduce
```
pip install git+http://gitlab.leibniz-kis.de/sdc/kis_tools
```
or
```bash
git clone http://gitlab.leibniz-kis.de/sdc/kis_tools
cd kis_tools
pip install .
```
## Expected Results
install
## Actual Results
```bash
ERROR: Command errored out with exit status 1:
command: /usr/local/bin/python -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-req-build-bp2qmtu2/setup.py'"'"'; __file__='"'"'/tmp/pip-req-build-bp2qmtu2/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-pip-egg-info-pnyed1_p
cwd: /tmp/pip-req-build-bp2qmtu2/
Complete output (15 lines):
Traceback (most recent call last):
File "<string>", line 1, in <module>
File "/tmp/pip-req-build-bp2qmtu2/setup.py", line 11, in <module>
info = get_git_info(force=True)
File "/tmp/pip-req-build-bp2qmtu2/kis_tools/util/gitinfo/__init__.py", line 43, in get_git_info
write_git_info(path_in)
File "/tmp/pip-req-build-bp2qmtu2/kis_tools/util/gitinfo/__init__.py", line 25, in write_git_info
commit = git_info(dirpath)
File "/tmp/pip-req-build-bp2qmtu2/kis_tools/util/gitinfo/gitinfo.py", line 99, in get_git_info
return get_git_info_dir(gitdir)
File "/tmp/pip-req-build-bp2qmtu2/kis_tools/util/gitinfo/gitinfo.py", line 80, in get_git_info_dir
return get_pack_info(idx_file, gi)
File "/tmp/pip-req-build-bp2qmtu2/kis_tools/util/gitinfo/pack_reader.py", line 112, in get_pack_info
data = zlib.decompress(fin.read(obj_len))
zlib.error: Error -5 while decompressing data: incomplete or truncated stream
----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.
```https://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/267LARS: add wavelenght fix as shell script2020-12-17T12:03:23ZCarl SchafferLARS: add wavelenght fix as shell scriptLARS doesn't add wavelength info to the header by default. We need to add it post-fact by querying it from the data. There is an IDL routine but python would be nicer. Add a cmdline script to add the InfoLARS doesn't add wavelength info to the header by default. We need to add it post-fact by querying it from the data. There is an IDL routine but python would be nicer. Add a cmdline script to add the Infohttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/271clean GRIS header2021-03-22T08:26:49ZCarl Schafferclean GRIS headerAfter discussing with Manolo and Carlos while working on [the slit orientation issue](https://leibniz-kis.atlassian.net/browse/SR-99?atlOrigin=eyJpIjoiMTE2ZjAzN2EwNjlhNDc5MmFiYTdmMDYzZTNkOGYyOTkiLCJwIjoiaiJ9) I found out that some of the...After discussing with Manolo and Carlos while working on [the slit orientation issue](https://leibniz-kis.atlassian.net/browse/SR-99?atlOrigin=eyJpIjoiMTE2ZjAzN2EwNjlhNDc5MmFiYTdmMDYzZTNkOGYyOTkiLCJwIjoiaiJ9) I found out that some of the values we are propagating in the GRIS header are not correct, they might:
* be historic values such as `SLITORIE` which do not have a well-defined or obvious function
* be values that apply only to observations but not single slit positions (e.g. `AZIMUT`, `ELEVATION`)
* be unreliable due to different ephemerides code used for producing them/not be compliant with the telescope's definitions (again `AZIMUTH`)
For fully consistent headers, we would need to go through each value, assess the definition and validity, document that and throw out all confusing values.https://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/276refactor gdbs implementation2021-03-26T10:59:38ZCarl Schafferrefactor gdbs implementationGDBS implementation is not universal, testing is dependent on the availablity of the gdbs host, needs more flexible and clearer implementation and interfaceGDBS implementation is not universal, testing is dependent on the availablity of the gdbs host, needs more flexible and clearer implementation and interfacehttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/277penumbral mask previews2021-04-27T07:57:53ZCarl Schafferpenumbral mask previewsTitle of penumbra previews should explain what the user is seeingTitle of penumbra previews should explain what the user is seeinghttps://gitlab.leibniz-kis.de/sdc/kis_tools/-/issues/278gris_header: FITS Liberator compatibility2021-05-03T08:02:02ZCarl Schaffergris_header: FITS Liberator compatibility